Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NetAdapterRename] Allow rename with HyperV Device Naming #523

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[NetAdapterRename] Allow rename with HyperV Device Naming #523

wants to merge 3 commits into from
+105 −17

Conversation

nyanhp
Copy link
Contributor

@nyanhp nyanhp commented Apr 18, 2023 •
edited by johlju
Loading

Pull Request (PR) description

On Hyper-V VMs, if Device Naming is configured, an advanced property is present that can be used to filter for
a NetAdapter renaming.

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@nyanhp
Copy link
Contributor Author

nyanhp commented Apr 18, 2023

Pipeline fails due to dsccommunity/DscResource.DocGenerator#131

@codecov
Copy link

codecov bot commented Apr 24, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97%. Comparing base (e8b5edc) to head (fdfa558).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #523   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        28     28           
  Lines      2078   2081    +3     
===================================
+ Hits       2028   2031    +3     
  Misses       50     50
Files with missing lines Coverage Δ
...sources/DSC_NetAdapterName/DSC_NetAdapterName.psm1 100% <100%> (ø)
...les/NetworkingDsc.Common/NetworkingDsc.Common.psm1 96% <100%> (+<1%) ⬆️

@PlagueHO PlagueHO self-requested a review June 1, 2024 00:51
@PlagueHO
Copy link
Member

PlagueHO commented Jun 1, 2024

Hi @nyanhp - sorry I missed this. I'm fixing pipeline and will then review (see #528 ).

@PlagueHO PlagueHO mentioned this pull request Jun 1, 2024
Merged
9 tasks
@johlju johlju added the needs review The pull request needs a code review. label Jun 7, 2024
@johlju
Copy link
Member

johlju commented Jun 7, 2024

This PR can be rebased now.

@PlagueHO
Copy link
Member

Hi @nyanhp - Reminder to rebase this PR so we can review.

@johlju
Copy link
Member

johlju commented Oct 27, 2024

It was just the changelog that had conflicts so I fixed that so it can be reviewed. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlagueHO PlagueHO Awaiting requested review from PlagueHO

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyanhp @PlagueHO @johlju